Impossible d'appeler notifyItemInserted () à partir de RecyclerView.OnScrollListener
Récemment, j'ai mis à niveau mon recyclerview-v7:23 vers recyclerview-v7:24.2.0. Mon application a une liste de défilement sans fin. Le message d'erreur pointe vers la ligne notifyItemInserted lorsque j'ajoute la vue de chargement dans RecyclerView (l'objet null signifie chargement, id 0 est vide, -1 en fin de page) et cela fonctionne correctement avant (recyclerview-v7: 23), mais tout à coup je Vous avez une erreur comme celle-ci et, d'une manière ou d'une autre, mon chargement apparaît deux fois, puis quand il en supprime un, il y en a un qui reste visible dans le haut.
W/RecyclerView: Cannot call this method in a scroll callback. Scroll callbacks might be run during a measure & layout pass where you cannot change the RecyclerView data. Any method call that might change the structure of the RecyclerView or the adapter contents should be postponed to the next frame.Java.lang.IllegalStateException:
at Android.support.v7.widget.RecyclerView.assertNotInLayoutOrScroll(RecyclerView.Java:2403)
at Android.support.v7.widget.RecyclerView$RecyclerViewDataObserver.onItemRangeInserted(RecyclerView.Java:4631)
at Android.support.v7.widget.RecyclerView$AdapterDataObservable.notifyItemRangeInserted(RecyclerView.Java:10469)
at Android.support.v7.widget.RecyclerView$Adapter.notifyItemInserted(RecyclerView.Java:6211)
at com.sketchproject.infogue.fragments.MessageFragment.loadMessages(MessageFragment.Java:109)
at com.sketchproject.infogue.fragments.MessageFragment.access$100(MessageFragment.Java:42)
at com.sketchproject.infogue.fragments.MessageFragment$1.onLoadMore(MessageFragment.Java:87)
at com.sketchproject.infogue.modules.EndlessRecyclerViewScrollListener.onScrolled(EndlessRecyclerViewScrollListener.Java:74)
Lorsque je supprime la partie d'erreur (ajout du chargement), cela fonctionne à nouveau correctement. Je ne sais pas pourquoi. Si la version plus récente de Recyclerview empêche l'ajout trop rapide de données dans l'adaptateur ou si une fonction de rappel est déclenchée lorsque "measure & layout" de recyclerview terminé, c'est mon code
private void loadArticles(final int page) {
if (!isEndOfPage && apiArticleUrl != null) {
if (swipeRefreshLayout == null || !swipeRefreshLayout.isRefreshing()) {
allArticles.add(null);
articleAdapter.notifyItemInserted(allArticles.size() - 1); // error here
}
JsonObjectRequest articleRequest = new JsonObjectRequest(Request.Method.GET, apiArticleUrl, null,
new Response.Listener<JSONObject>() {
@Override
public void onResponse(JSONObject response) {
try {
String status = response.getString("status");
JSONObject articles = response.getJSONObject("articles");
String nextUrl = articles.getString("next_page_url");
int currentPage = articles.getInt("current_page");
int lastPage = articles.getInt("last_page");
JSONArray data = articles.optJSONArray("data");
apiArticleUrl = nextUrl;
if (status.equals(APIBuilder.REQUEST_SUCCESS)) {
if (swipeRefreshLayout == null || !swipeRefreshLayout.isRefreshing()) {
allArticles.remove(allArticles.size() - 1);
articleAdapter.notifyItemRemoved(allArticles.size());
} else {
swipeRefreshLayout.setRefreshing(false);
int total = allArticles.size();
for (int i = 0; i < total; i++) {
allArticles.remove(0);
}
articleAdapter.notifyItemRangeRemoved(0, total);
}
List<Article> moreArticles = new ArrayList<>();
if (data != null) {
for (int i = 0; i < data.length(); i++) {
JSONObject articleData = data.getJSONObject(i);
Article article = new Article();
article.setId(articleData.getInt(Article.ID));
article.setSlug(articleData.getString(Article.SLUG));
article.setTitle(articleData.getString(Article.TITLE));
article.setFeatured(articleData.getString(Article.FEATURED_REF));
article.setCategoryId(articleData.getInt(Article.CATEGORY_ID));
article.setCategory(articleData.getString(Article.CATEGORY));
article.setSubcategoryId(articleData.getInt(Article.SUBCATEGORY_ID));
article.setSubcategory(articleData.getString(Article.SUBCATEGORY));
article.setContent(articleData.getString(Article.CONTENT));
article.setContentUpdate(articleData.getString(Article.CONTENT_UPDATE));
article.setPublishedAt(articleData.getString(Article.PUBLISHED_AT));
article.setView(articleData.getInt(Article.VIEW));
article.setRating(articleData.getInt(Article.RATING_TOTAL));
article.setStatus(articleData.getString(Article.STATUS));
moreArticles.add(article);
}
}
int curSize = articleAdapter.getItemCount();
allArticles.addAll(moreArticles);
if (allArticles.size() <= 0) {
Log.i("INFOGUE/Article", "Empty on page " + page);
isEndOfPage = true;
Article emptyArticle = new Article(0, null, "Empty page");
allArticles.add(emptyArticle);
} else if (currentPage >= lastPage) {
Log.i("INFOGUE/Article", "End on page " + page);
isEndOfPage = true;
Article endArticle = new Article(-1, null, "End of page");
allArticles.add(endArticle);
}
articleAdapter.notifyItemRangeInserted(curSize, allArticles.size() - 1);
} else {
Log.i("INFOGUE/Article", "Error on page " + page);
Helper.toastColor(getContext(), R.string.error_unknown, R.color.color_warning_transparent);
isEndOfPage = true;
Article failureArticle = new Article();
failureArticle.setId(-2);
failureArticle.setTitle(getString(R.string.error_unknown));
allArticles.add(failureArticle);
}
} catch (JSONException e) {
e.printStackTrace();
}
}
},
new Response.ErrorListener() {
@Override
public void onErrorResponse(VolleyError error) {
error.printStackTrace();
if (swipeRefreshLayout != null && swipeRefreshLayout.isRefreshing()) {
swipeRefreshLayout.setRefreshing(false);
}
// remove last loading
allArticles.remove(allArticles.size() - 1);
articleAdapter.notifyItemRemoved(allArticles.size());
String errorMessage = getString(R.string.error_unknown);
NetworkResponse networkResponse = error.networkResponse;
if (networkResponse == null) {
if (error.getClass().equals(TimeoutError.class)) {
errorMessage = getString(R.string.error_timeout);
} else if (error.getClass().equals(NoConnectionError.class)) {
errorMessage = getString(R.string.error_no_connection);
}
} else {
if (networkResponse.statusCode == 404) {
errorMessage = getString(R.string.error_not_found);
} else if (networkResponse.statusCode == 500) {
errorMessage = getString(R.string.error_server);
} else if (networkResponse.statusCode == 503) {
errorMessage = getString(R.string.error_maintenance);
}
}
Helper.toastColor(getContext(), errorMessage, R.color.color_danger_transparent);
// add error view holder
isEndOfPage = true;
Article errorArticle = new Article();
errorArticle.setId(-2);
errorArticle.setTitle(errorMessage);
allArticles.add(errorArticle);
}
}
);
articleRequest.setTag("articles");
articleRequest.setRetryPolicy(new DefaultRetryPolicy(
APIBuilder.TIMEOUT_SHORT,
DefaultRetryPolicy.DEFAULT_MAX_RETRIES,
DefaultRetryPolicy.DEFAULT_BACKOFF_MULT));
VolleySingleton.getInstance(getContext()).addToRequestQueue(articleRequest);
}
}
ce code a été appelé par la méthode onCreate
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View view = inflater.inflate(R.layout.fragment_article_list, container, false);
// Set the adapter
if (view instanceof RecyclerView) {
Context context = view.getContext();
recyclerView = (RecyclerView) view;
// determine column of list
LinearLayoutManager linearLayoutManager;
if (mColumnCount <= 1) {
linearLayoutManager = new LinearLayoutManager(context);
} else {
linearLayoutManager = new GridLayoutManager(context, mColumnCount);
}
// if article list authored by logged user then prefer editable view holder
if (mMyArticle) {
articleAdapter = new ArticleRecyclerViewAdapter(allArticles, mArticleListListener, mArticleEditableListener);
} else {
articleAdapter = new ArticleRecyclerViewAdapter(allArticles, mArticleListListener, hasHeader);
}
// set the adapter and attach custom scroll listener that triggered onLoadMore() and onReachTop()
recyclerView.setAdapter(articleAdapter);
recyclerView.setLayoutManager(linearLayoutManager);
recyclerView.addOnScrollListener(new EndlessRecyclerViewScrollListener(linearLayoutManager) {
@Override
public void onLoadMore(final int page, int totalItemsCount) {
if (!isFirstCall) {
loadArticles(page);
}
}
@Override
public void onReachTop(boolean isFirst) {
// activate swipe function when list reach top only, find out where do fragment attached
if (getActivity() instanceof ArticleActivity) {
((ArticleActivity) getActivity()).setSwipeEnable(isFirst);
} else if (getActivity() instanceof ApplicationActivity) {
((ApplicationActivity) getActivity()).setSwipeEnable(isFirst);
}
}
});
if (isFirstCall) {
isFirstCall = false;
loadArticles(0);
}
}
return view;
}
Mes questions sont:
- Le problème provient-il de la nouvelle version de
RecyclerView? - Est-il faux d'implémenter
notifyItemInserteddans l'écouteur de défilement? Cela a fonctionné avant. - Comment puis-je résoudre ce problème?
Mis à jour
when I logged the code inside first call and scroll,
09-12 03:49:10.078 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers URL http://192.168.43.141:8000/api/contributor/support/followers?contributor_id=1
09-12 03:49:26.421 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers first call
09-12 03:49:26.421 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers URL http://192.168.43.141:8000/api/contributor/support/followers?contributor_id=1
09-12 03:49:26.617 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers second call (scroll)
09-12 03:49:26.618 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers URL http://192.168.43.141:8000/api/contributor/support/followers?contributor_id=1
09-12 03:49:27.365 7046-7046/com.sketchproject.infogue I/Infogue/Contributor: Followers second call (scroll)
Ils sont appelés deux fois lors du premier chargement, après le premier appel et l’ajout de la vue de chargement, le défilement est déclenché et un nouvel appel.
Vous pouvez également poster en utilisant la vue.
recyclerView.post(new Runnable() {
public void run() {
articleAdapter.notifyItemInserted(allArticles.size() - 1);
}
});
- Le problème ne concerne pas la nouvelle version de Recyclerview.
2 et 3. Vous ne pouvez pas changer d'élément pendant le réglage (en appelant onBindViewHolder). Dans ce cas, vous devez appeler notifyItemInserted à la fin de la boucle en cours en appelant Handler.post ().
Handler handler = new Handler();
final Runnable r = new Runnable() {
public void run() {
articleAdapter.notifyItemInserted(allArticles.size() - 1);
}
};
handler.post(r);
J'espère que cela résoudra votre problème.
Vous pouvez également utiliser le API de tâches du service Google Play
Tasks.call(new Callable<Void>() {
@Override
public Void call() throws Exception {
allArticles.add(null);
articleAdapter.notifyItemInserted(allArticles.size() - 1);
return null;
}
});
Dans certains cas, onScrollStateChanged peut suffire
override fun onScrollStateChanged(recyclerView: RecyclerView?, newState: Int) {
super.onScrollStateChanged(recyclerView, newState)
adapter.notifyDataSetChanged()
}